Skip to content

Rails 6.1: fix rake task #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2021
Merged

Rails 6.1: fix rake task #904

merged 2 commits into from
Apr 21, 2021

Conversation

@mgrunberg
Copy link
Contributor

@mgrunberg mgrunberg commented Apr 21, 2021

Two changes:

  1. configuration_hash keys are symbols, not strings.
  2. ActiveRecord::Tasks::DatabaseTasks.load_schema requires a ActiveRecord::DatabaseConfigurations::HashConfig instance

@wpolicarpo wpolicarpo merged commit 2b5a37a into rails-sqlserver:main Apr 21, 2021
@mgrunberg mgrunberg deleted the issues/yellowspot/rails-6-1/fix-rake-task branch January 3, 2022 17:32
lavika pushed a commit to lavika/activerecord-sqlserver-adapter that referenced this pull request Sep 26, 2023
@mgrunberg
Rails 6.1: fix rake task (rails-sqlserver#904)
8386b77 
* configuration_hash use symbols as keys

* db_tasks.load_schema requires db_config object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgrunberg @wpolicarpo