Rails 6.1: Skip tests on Windows because of atomic write issue #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coercing tests on Windows that rely on
SchemaCache#dump_to. The call in https://github.com/rails/rails/blob/e2781c2d93808031fbc4dbecaa7aac59aa90b4b8/activesupport/lib/active_support/core_ext/file/atomic.rb#L50 to rename the file fails on Windows. This is a Rails/Windows issue.MacOS
Windows
An example of exception raised is (https://ci.appveyor.com/project/wpolicarpo/activerecord-sqlserver-adapter/builds/38929321#L397):
Also in this PR, no longer need to coerce the
DatabaseTasksDumpSchemaCacheTest#test_dump_schema_cachetest as it has been updated on the Rails test suite and will now work on Windows.