Rails 6.1: Read file in binary mode to support the Windows CI #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being binary read
aidanharan
force-pushed
the
load-legacy-file-windows-binary
branch
from
b62e896 to
3d89b16
Compare
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
… being binary read (rails-sqlserver#922) Co-authored-by: Aidan Haran <aharan@fusioneer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coerced and re-implemented the
ActiveRecord::RelationTest#test_marshal_load_legacy_relationtest as the original Rails test was not reading the dump file in binary mode and so wasn't passing on Windows environments.The coerce can be removed on Rails 7+ as the test was removed in rails/rails@0e35e67#diff-744b39fde5c3433ab31f1fe1721fde897ebde5c0abb5a09e6752a1479ac42668