Fix tests for Rails 6.1.4 #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete records that were created as part of test before adding index back Fix test
aidanharan
force-pushed
the
fix-rails6.1.4-tests
branch
from
6d6e7cb to
a864604
Compare
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
Delete records that were created as part of test before adding index back Fix test Co-authored-by: Aidan Haran <aharan@fusioneer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coerce and re-implement the Rails 6.1.4
LogSubscriberTest#test_where_in_binds_logging_include_attribute_namestest so that the adapter now passes for Rails 6.1.4.Also, some CI tests started failing because records created during the test prevented the index from being added back. This issue does not happen locally. To fix the issue I delete the records created during the original test before adding the index back. This change does not affect the purpose of the test.