Fix schema cache generation #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpolicarpo
force-pushed
the
fix-schema-cache
branch
from
8597b9c to
4989313
Compare
wpolicarpo
force-pushed
the
fix-schema-cache
branch
from
4989313 to
028d3af
Compare
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
SQLServer::Column(formerSQLServerColumn) andSQLServer::TypeMetadataso it includes the SQL Server's specific attributes.Instead of having a Hash with all SQL Server attributes, the logic was changed to handle named attributes the same way the Postgres adapter does. This is to make sure all attributes are dumped into the schema cache once necessary and to make it more compliant with what Rails does internally.
Important
This is a breaking change comparing to older versions and if you have a
schema_cache.{yml,dump}, a fresh dump will be necessary.Fix #696.