Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/active_resource/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ module ActiveResource
# * 410 - ActiveResource::ResourceGone
# * 412 - ActiveResource::PreconditionFailed
# * 422 - ActiveResource::ResourceInvalid (rescued by save as validation errors)
# * 429 - ActiveResource::TooManyRequests
# * 401..499 - ActiveResource::ClientError
# * 500..599 - ActiveResource::ServerError
# * Other - ActiveResource::ConnectionError
Expand Down
2 changes: 2 additions & 0 deletions lib/active_resource/connection.rb
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ def handle_response(response)
raise(PreconditionFailed.new(response))
when 422
raise(ResourceInvalid.new(response))
when 429
raise(TooManyRequests.new(response))
when 401...500
raise(ClientError.new(response))
when 500...600
Expand Down
4 changes: 4 additions & 0 deletions lib/active_resource/exceptions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ class ResourceGone < ClientError # :nodoc:
class PreconditionFailed < ClientError # :nodoc:
end

# 429 Too Many Requests
class TooManyRequests < ClientError # :nodoc:
end

# 5xx Server Error
class ServerError < ConnectionError # :nodoc:
end
Expand Down
3 changes: 3 additions & 0 deletions test/cases/connection_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ def test_handle_response
# 422 is a validation error
assert_response_raises ActiveResource::ResourceInvalid, 422

# 429 is too many requests
assert_response_raises ActiveResource::TooManyRequests, 429

# 4xx are client errors.
[402, 499].each do |code|
assert_response_raises ActiveResource::ClientError, code
Expand Down