Validations: Configure which status codes to rescue from #444
+54
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem --- The established convention is for resources to rescue from `422 Unprocessable Content` responses by raising an `ActiveResource::ResourceInvalid` exception. The mixed-in `ActiveResource::Validation` module rescues from `ActiveResource::ResourceInvalid`, then parses error messages from the response body. This works for many remote services, but there are other status codes that remote services might respond with that include resource-specific error messages. For example, a service could respond with a more generic status of `400 Bad Request` to indicate that the request was invalid. If the response includes error messages, it could be important to import them into the resource's error messages. The proposal --- Introduce the `Base.remote_errors` attribute (named to match the style of the `@remote_errors` instance variable and the `#load_remote_errors` private method) to control which errors to rescue from. The default value remains `ActiveResource::ResourceInvalid`.
seanpdoyle
force-pushed
the
validation-error-classes
branch
from
8ac5eb0 to
62bee80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The established convention is for resources to rescue from
422 Unprocessable Contentresponses by raising anActiveResource::ResourceInvalidexception. The mixed-inActiveResource::Validationmodule rescues fromActiveResource::ResourceInvalid, then parses error messages from the response body.This works for many remote services, but there are other status codes that remote services might respond with that include resource-specific error messages.
For example, a service could respond with a more generic status of
400 Bad Requestto indicate that the request was invalid. If the response includes error messages, it could be important to import them into the resource's error messages.The proposal
Introduce the
Base.remote_errorsattribute (named to match the style of the@remote_errorsinstance variable and the#load_remote_errorsprivate method) to control which errors to rescue from. The default value remainsActiveResource::ResourceInvalid.