Revert to immediately retrieved collections by default #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rails#460 Introduce both the `config.active_resource.lazy_collections` configuration, as well as the `Base.lazy_collections` class attribute. Restore the original behavior of immediately retrieving collections by defaulting the initial value to `false`, but deprecate the behavior and encourage migrating to setting the value to `true`.
Contributor
Author
|
Closing in favor of #460 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #460
Introduce both the
config.active_resource.lazy_collectionsconfiguration, as well as theBase.lazy_collectionsclass attribute.Restore the original behavior of immediately retrieving collections by defaulting the initial value to
false, but deprecate the behavior and encourage migrating to setting the value totrue.