Skip to content

Revert fixes involving issue #99 (which makes Arel unusable in large datasets) #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaelfranca merged 2 commits into from
Mar 15, 2013
Merged

Revert fixes involving issue #99 (which makes Arel unusable in large datasets) #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5399048
Revert issue #99 fixes
eduardordm Mar 15, 2013
47d5302
Update test_oracle.rb
eduardordm Mar 15, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/arel/visitors/oracle.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@ def visit_Arel_Nodes_SelectStatement o
SELECT * FROM (
SELECT raw_sql_.*, rownum raw_rnum_
FROM (#{sql}) raw_sql_
WHERE rownum <= #{offset.expr.to_i + limit}
)
WHERE raw_rnum_ >= #{offset.expr.to_i + 1 } and rownum <= #{limit}
WHERE #{visit offset}
eosql
end

Expand Down
3 changes: 2 additions & 1 deletion test/visitors/test_oracle.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,9 @@ module Visitors
SELECT * FROM (
SELECT raw_sql_.*, rownum raw_rnum_
FROM (SELECT) raw_sql_
WHERE rownum <= 20
)
WHERE raw_rnum_ >= 11 and rownum <= 10
WHERE raw_rnum_ > 10
}
end

Expand Down