Ignore disabled file input #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled file input form should be ignored, however currently submitting a form with disabled file input will cause issue on Rails' side.
Member
|
I think we can't test it due to be impossible to set file value programatically. |
rafaelfranca
added a commit
that referenced
this pull request
Sep 1, 2015
Ignore disabled file input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled file input form should be ignored,
however currently submitting a form with disabled file input will cause issue on Rails' side.
A minimal demo is provided: https://github.com/lulalala/ujs-bug
There are 2 commits, the first one is before the patch, the second one is after the patch.
Run the app, navigate to http://localhost:3000/posts/new
Choose a file, and then that file will be disabled. Then submit the form.
Before the patch, form submission will raise
ActionController::InvalidAuthenticityTokenAfter the patch, form submission will be successful (the file input will be ignored completely).
This demo may seem a bit contrived, but in my actual app I have a valid requirement that is using ujs together with remotipart and conditional file input.
If someone can give me some idea as to how to test this it would be great. Thanks.