Skip to content

assert_select doesn't select root element when asserting against xml. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2014
Merged

assert_select doesn't select root element when asserting against xml. #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cd9544
Add failing test showing disparity between html and xml.
kaspth Aug 22, 2014
2122655
Wrap document_root_element in nodeset so root is selectable.
kaspth Aug 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rails/dom/testing/assertions/selector_assertions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def determine_root_from(args, previous_selection = nil)
elsif previous_selection
previous_selection
else
document_root_element
nodeset document_root_element
end
end

Expand Down
13 changes: 13 additions & 0 deletions test/selector_assertions_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,18 @@ def test_substitution_values
end
end

def test_assert_select_root_html
render_html '<a></a>'

assert_select 'a'
end

def test_assert_select_root_xml
render_xml '<rss version="2.0"></rss>'

assert_select 'rss'
end

def test_nested_assert_select
render_html %Q{<div id="1">foo</div><div id="2">foo</div>}
assert_select "div" do |elements|
Expand Down Expand Up @@ -241,6 +253,7 @@ def test_feed_item_encoded
</channel>
</rss>
EOF

assert_select "channel item description" do

assert_select_encoded do
Expand Down