Introduce nodeset method. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
I didn't really see the point of this message being so specific? It just makes duck typing here harder.
@rafaelfranca
Contributor
Author
There was a problem hiding this comment.
I thought it was a little much to make it a full-blown object.
Ok? @rafaelfranca
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a pain to keep figuring out if we we're dealing with a
NodeorNodeSet. So polymorphism 😄There might be a problem if users ever pass in an array of elements (instead of a
NodeSet).For instance using an
Enumerablemethod likemapreturns an array.Which could confuse people... but then again why would they do that, when they already have
assert_selectto pick out elements?Which is why I've removed the
is_a?(Array)checks. It's easy to make sure we have a node set when needed.@rafaelfranca