Validate uniqueness of custom primary key #20966
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
presskey
force-pushed
the
validate_uniqueness_of_custom_primary_key
branch
from
534df3e to
2569ee8
Compare
presskey
force-pushed
the
validate_uniqueness_of_custom_primary_key
branch
from
2569ee8 to
2d58f58
Compare
Contributor
There was a problem hiding this comment.
These shouldn't be symbolized.
Contributor
|
I went ahead and fixed the issues I had with the implementation, added a changelog, and committed. You've been credited for the commit. 119b918 |
sgrif
added a commit
that referenced
this pull request
Jul 25, 2015
This is an alternate implementation of #20966. [Sean Griffin & presskey]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem in uniqueness validator that allowed model with custom primary key to pass validation when non unique primary key value was set which resulted in exception.