Skip to content

Conversation

@AndyLampert
Copy link
Contributor

No description provided.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @chancancode (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sgrif
Copy link
Contributor

sgrif commented Oct 6, 2015

Can you rebase this? It has merge conflicts w/ master.

@AndyLampert AndyLampert force-pushed the small-csrf-section-readability-improvements branch from 35e2d85 to 3122a8c Compare October 7, 2015 02:18
@AndyLampert
Copy link
Contributor Author

Thanks @sgrif . I think that'll do it.

@sgrif
Copy link
Contributor

sgrif commented Oct 7, 2015

Not quite. This PR is now two commits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it has actually dynamically creates → created*

@AndyLampert AndyLampert force-pushed the small-csrf-section-readability-improvements branch 4 times, most recently from be625e2 to 3c9b81b Compare October 8, 2015 03:30
@AndyLampert AndyLampert force-pushed the small-csrf-section-readability-improvements branch from 3c9b81b to 7058475 Compare October 8, 2015 04:12
@AndyLampert
Copy link
Contributor Author

Ok, phew. I think that's it! 😫

Also added your fix @jeremy - thanks for grammar the check!

sgrif added a commit that referenced this pull request Oct 8, 2015
…lity-improvements

Improve readability in CSRF section of guide [ci skip]
@sgrif sgrif merged commit 8a6cfbf into rails:master Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants