fix #except and #only with default_scope
#3143
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix Model.except(something) wouldn't get rid of 'something'
clauses in the query. Same thing for Model.only().
The two deleted lines were introduced here to "evaluate default scopes at the last possible moment" and that made impossible to remove conditions from the default scope. The behavior after this fix is the same we had before Rails 3.1, which means #except and #only can modify the default_scope.