Removed webpacker:compile step from scaffold test as it is not required#36778
Merged
rafaelfranca merged 1 commit intorails:masterfrom Jul 26, 2019
Merged
Conversation
…ed and assets are already precompiled in build_app step
rafaelfranca
added a commit
that referenced
this pull request
Jul 26, 2019
…compile-from-test Removed webpacker:compile step from scaffold test as it is not required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was working on adding webpacker to the Rails engines, my test cases were consistently failing and I had no idea what was wrong. So I checked how Rails app with webpacker solves the scaffold test scenario.
I found that when the Rails app is build using
build_appit compiles the assets here(https://github.com/rails/rails/blob/master/railties/test/isolation/abstract_unit.rb#L519-L526)This
webpacker:compilewas an unnecessary step but since these are test case I was not sure If I should raise PR for change. On my local test cases ran 2sec faster 😊 . Please close this PR if the change is not needed.