Move "Sprockets is now an optional dependency" to rails 7 upgrade notes #43799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosantoniodasilva
added a commit
that referenced
this pull request
Dec 8, 2021
…rect-version Move "Sprockets is now an optional dependency" to rails 7 upgrade notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This section was added in 411ffb4 under the "Upgrading from Rails 5.2 to Rails 6.0" chapter:
I'm guessing this was a mistake because the
sprockets-railsdependency wasn't removed until #43261 which is part of Rails 7.0. So this PR moves the "Sprockets is now an optional dependency" section to the "Upgrading from Rails 6.1 to Rails 7.0" chapter. I put it just after the note about the Spring version compatibility since both are about potential changes that should be made to theGemfilewhen upgrading.cc @rafaelfranca