Fix using TestServer in ConnectionStub #47483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
It's an internal testing entity, we cannot use it in a test case class
palkan
force-pushed
the
fix/channel-test-case-test-server
branch
from
54f841d to
8fff6d6
Compare
Contributor
|
I would not say official because it's nodoc'd 😂 but yup, this LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Closes #47377.
Detail
It's an alternative implementation to #47409.
The solution in #47409 suggest promoting TestServer to be an official part of the Action Cable, which, I believe, isn't a good idea. The whole purpose of Channels/Connections testing it to make it possible to test logic in isolation from any kind of a server.
This PR fixes the original server leakage by making channel dependent on the configuration (which is fine, it's a part of the abstraction, not implementation), without directly depending on a server.
Checklist
[Fix #issue-number]