Skip to content

Conversation

@p8
Copy link
Member

@p8 p8 commented Jul 2, 2023

has_one_attached and has_many_attached generate several scopes and relations:

  • with_attached_*
  • *_attachment
  • *_attachments
  • *_blob
  • *_blobs

But these are all undocumented.

We can document these methods similar to ee58c8e using the :method: directive.

image

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

`has_one_attached` and `has_many_attached` generate several scopes and
relations:

* `with_attached_*`
* `*_attachment`
* `*_attachments`
* `*_blob`
* `*_blobs`

But these are all undocumented.

We can document these methods similar to ee58c8e using the
`:method:` directive.
@p8 p8 merged commit 5694f1e into rails:main Jul 3, 2023
@p8 p8 deleted the activestorage/document-with-attached branch July 3, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants