Fix verbose redirect output and route source mapping #55889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would sometimes log nil when verbose logs are disabled, and dispatch route level source locations could not be found.
gmcgibbon
force-pushed
the
fix_verbose_redirect_logs
branch
from
c289c0a to
afe6924
Compare
chaadow
reviewed
Oct 14, 2025
|
|
||
| ### Notable changes | ||
|
|
||
| * Redirects are now verbose in development for new Rails apps. To enable it in an existing app, add `config.action_dispatch.verbose_redirect_logs = true` to your `config/development.rb` file. |
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Oct 15, 2025
This commit addresses the following failure with Ruby 3.5.0.dev since `source_location` includes start_column, end_line, end_column. Follow up rails#55889 - Fixed by this commit ```ruby $ ruby -v ruby 3.5.0dev (2025-10-14T22:26:08Z master df5d63cfa2) +PRISM [x86_64-linux] $ bin/test test/controller/log_subscriber_test.rb:331 Running 36 tests in a single process (parallelization threshold is 50) Run options: --seed 1476 F Failure: ACLogSubscriberTest#test_verbose_redirect_logs [test/controller/log_subscriber_test.rb:331]: Expected /\u21B3 \/home\/yahonda\/src\/github.com\/rails\/rails\/actionpack\/test\/controller\/log_subscriber_test.rb:8/ to match "↳ /home/yahonda/src/github.com/rails/rails/actionpack/test/controller/log_subscriber_test.rb:28:in 'Another::LogSubscribersController#redirector'". bin/test test/controller/log_subscriber_test.rb:320 Finished in 0.063581s, 15.7279 runs/s, 47.1836 assertions/s. 1 runs, 3 assertions, 1 failures, 0 errors, 0 skips $ ``` - Additional information - Modified to show the entire source_location ``` $ git diff -- test/controller/log_subscriber_test.rb diff --git a/actionpack/test/controller/log_subscriber_test.rb b/actionpack/test/controller/log_subscriber_test.rb index 0b6e5b0..e19848b769 100644 --- a/actionpack/test/controller/log_subscriber_test.rb +++ b/actionpack/test/controller/log_subscriber_test.rb @@ -318,6 +318,7 @@ def test_filter_redirect_bad_uri end def test_verbose_redirect_logs + pp Another::LogSubscribersController.instance_method(:redirector).source_location line = Another::LogSubscribersController.instance_method(:redirector).source_location.last + 1 old_cleaner = ActionController::LogSubscriber.backtrace_cleaner ActionController::LogSubscriber.backtrace_cleaner = ActionController::LogSubscriber.backtrace_cleaner.dup $ ``` - Ruby 3.5.0dev source_location returns an array of 5 elements. ``` $ ruby -v ruby 3.5.0dev (2025-10-14T22:26:08Z master df5d63cfa2) +PRISM [x86_64-linux] yahonda@myubuntu:~/src/github.com/rails/rails/actionpack$ bin/test test/controller/log_subscriber_test.rb:331 Running 36 tests in a single process (parallelization threshold is 50) Run options: --seed 37374 ["/home/yahonda/src/github.com/rails/rails/actionpack/test/controller/log_subscriber_test.rb", 27, 4, 29, 7] F Failure: ACLogSubscriberTest#test_verbose_redirect_logs [test/controller/log_subscriber_test.rb:332]: Expected /\u21B3 \/home\/yahonda\/src\/github.com\/rails\/rails\/actionpack\/test\/controller\/log_subscriber_test.rb:8/ to match "↳ /home/yahonda/src/github.com/rails/rails/actionpack/test/controller/log_subscriber_test.rb:28:in 'Another::LogSubscribersController#redirector'". bin/test test/controller/log_subscriber_test.rb:320 Finished in 0.067459s, 14.8237 runs/s, 44.4712 assertions/s. 1 runs, 3 assertions, 1 failures, 0 errors, 0 skips $ ``` - Ruby 3.4.7 source_location returns an array of 2 elements. ``` $ ruby -v ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +PRISM [x86_64-linux] $ bin/test test/controller/log_subscriber_test.rb:331 Running 36 tests in a single process (parallelization threshold is 50) Run options: --seed 6959 ["/home/yahonda/src/github.com/rails/rails/actionpack/test/controller/log_subscriber_test.rb", 27] . Finished in 0.067913s, 14.7247 runs/s, 44.1740 assertions/s. 1 runs, 3 assertions, 0 failures, 0 errors, 0 skips $ ``` https://bugs.ruby-lang.org/issues/6012 ruby/ruby#12539
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Oct 15, 2025
This commit addresses the following failure with Ruby 3.5.0.dev since `source_location` includes start_column, end_line, end_column. Follow up rails#55889 - Fixed by this commit ```ruby $ ruby -v ruby 3.5.0dev (2025-10-14T22:26:08Z master df5d63cfa2) +PRISM [x86_64-linux] $ bin/test test/controller/log_subscriber_test.rb:331 Running 36 tests in a single process (parallelization threshold is 50) Run options: --seed 1476 F Failure: ACLogSubscriberTest#test_verbose_redirect_logs [test/controller/log_subscriber_test.rb:331]: Expected /\u21B3 \/home\/yahonda\/src\/github.com\/rails\/rails\/actionpack\/test\/controller\/log_subscriber_test.rb:8/ to match "↳ /home/yahonda/src/github.com/rails/rails/actionpack/test/controller/log_subscriber_test.rb:28:in 'Another::LogSubscribersController#redirector'". bin/test test/controller/log_subscriber_test.rb:320 Finished in 0.063581s, 15.7279 runs/s, 47.1836 assertions/s. 1 runs, 3 assertions, 1 failures, 0 errors, 0 skips $ ``` - Additional information - Modified to show the entire source_location ``` $ git diff -- test/controller/log_subscriber_test.rb diff --git a/actionpack/test/controller/log_subscriber_test.rb b/actionpack/test/controller/log_subscriber_test.rb index 0b6e5b0..e19848b769 100644 --- a/actionpack/test/controller/log_subscriber_test.rb +++ b/actionpack/test/controller/log_subscriber_test.rb @@ -318,6 +318,7 @@ def test_filter_redirect_bad_uri end def test_verbose_redirect_logs + pp Another::LogSubscribersController.instance_method(:redirector).source_location line = Another::LogSubscribersController.instance_method(:redirector).source_location.last + 1 old_cleaner = ActionController::LogSubscriber.backtrace_cleaner ActionController::LogSubscriber.backtrace_cleaner = ActionController::LogSubscriber.backtrace_cleaner.dup $ ``` - Ruby 3.5.0dev source_location returns an array of 5 elements. ``` $ ruby -v ruby 3.5.0dev (2025-10-14T22:26:08Z master df5d63cfa2) +PRISM [x86_64-linux] $ bin/test test/controller/log_subscriber_test.rb:331 Running 36 tests in a single process (parallelization threshold is 50) Run options: --seed 37374 ["/home/yahonda/src/github.com/rails/rails/actionpack/test/controller/log_subscriber_test.rb", 27, 4, 29, 7] F Failure: ACLogSubscriberTest#test_verbose_redirect_logs [test/controller/log_subscriber_test.rb:332]: Expected /\u21B3 \/home\/yahonda\/src\/github.com\/rails\/rails\/actionpack\/test\/controller\/log_subscriber_test.rb:8/ to match "↳ /home/yahonda/src/github.com/rails/rails/actionpack/test/controller/log_subscriber_test.rb:28:in 'Another::LogSubscribersController#redirector'". bin/test test/controller/log_subscriber_test.rb:320 Finished in 0.067459s, 14.8237 runs/s, 44.4712 assertions/s. 1 runs, 3 assertions, 1 failures, 0 errors, 0 skips $ ``` - Ruby 3.4.7 source_location returns an array of 2 elements. ``` $ ruby -v ruby 3.4.7 (2025-10-08 revision 7a5688e2a2) +PRISM [x86_64-linux] $ bin/test test/controller/log_subscriber_test.rb:331 Running 36 tests in a single process (parallelization threshold is 50) Run options: --seed 6959 ["/home/yahonda/src/github.com/rails/rails/actionpack/test/controller/log_subscriber_test.rb", 27] . Finished in 0.067913s, 14.7247 runs/s, 44.1740 assertions/s. 1 runs, 3 assertions, 0 failures, 0 errors, 0 skips $ ``` https://bugs.ruby-lang.org/issues/6012 ruby/ruby#12539
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because #52297 isn't working exactly the way I expected.
Previously, we would sometimes log nil when verbose logs are disabled, and dispatch route level source locations could not be found.
Detail
This Pull Request changes mostly dispatch code to record some source location in redirect endpoints when needed. This allows this feature to work in environments other than development, if needed, instead of depending on the other route source locations feature.
This adds an additional parameter to
redirect.action_dispatchwhich may not be desirable. We can instead hack the caller trace to include the source location or use route source locations. Open to feedback on this, but I prefer to keep things simple here with an event parameter.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]