Save a string allocation for each attribute method call #38355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the attribute method proxy call would systematically instantiate the same string over and over:
It's not a lot per say, but it can easily add up.
Backward compatibility
It's possible that there are attribute methods out there that mutate the received attribute name, but IMHO it's quite an edge case and easy to fix.
cc @rafaelfranca @Edouard-chin