Adds Yes/No to ActiveModel::Type::Boolean options. #42971
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdewater
reviewed
Aug 16, 2021
|
Any chance of receiving guidance from someone on this? I wonder what else I could do to move forward. |
This was referenced Sep 3, 2021
Closed
websebdev
reviewed
Sep 4, 2021
|
FWIW I'm pro this change! |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Is there an interest to move forward with this change? Am I still missing something? I'm willing to make any further changes that might help. |
|
We prefer to not change this type in Rails since it can break existing applications. But feel free to define your own Boolean type and change the type registry to use your type by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
My experience shows that end users tend to understand Yes/No pair better than True/False. This is a very common case in my projects when consuming CSV files provided by users, for example. As it seems to me that Yes/No are not ambiguous terms, I'm hoping ActiveModel could handle them without any major risks to existing codebases.
Other Information
I looked at the documentation and I believe it doesn't need to be changed, but I'm glad to make further changes as seen fit.
I believe this is self containing? Happy to edit if I'm missing any information.