Fix date_select [3-2-stable] #4640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Valim <jose.valim@gmail.com>
After 15fb430 the default location of the :sql schema_format location was changed from environment_name.sql to structure.sql. This pull request updates a reference to the old schema format location in the migration guides.
fix adding field_with_errors to date selects, closes rails#3487
It should be README.rdoc
Fix regression in select form helper when options are non-string values
…estTaskWithoutDescription.
This makes it easier to add your own tests to the default suite:
namespace :test do
task run: 'test:acceptance'
Rails::SubTestTask.new acceptance: 'test:prepare' do |t|
t.libs << 'test'
t.pattern = 'test/acceptance/**/*_test.rb'
end
end
Now `rake` runs unit, functional, integration, and acceptance tests.
… with strict mass assignment sanitizer, fixed build_record to not merge creation_attributes, removed failing nested attributes tests (that feature was broken anyway) rails#4051 Signed-off-by: José Valim <jose.valim@gmail.com>
…erer#determine_template Signed-off-by: José Valim <jose.valim@gmail.com>
Doc fixes 3 2 stable
…&:method) *DHH*" This reverts commit 4d20de8.
* '3-2-stable' of github.com:rails/rails: [docs] added missing "}" fixes rails#4126
…aggedLogging::ERROR
Fix GH rails#4580. Rails 3.2: uninitialized constant ActiveSupport::TaggedLogging::ERROR
activesupport tests.
…warnings Assert with no deprecation warnings activesupport tests.
…value of $rails_rake_task if it is already set. Fixes rails#4591. Signed-off-by: José Valim <jose.valim@gmail.com>
3-2-stable: Fixed regression - unable to use a range as choices for form.select.
…ne with bash, zsh, etc, closes rails#4602
…se64.decode64 not ::Base64.encode64
Fix ActiveSupport::Base64.decode64
Add missing require to Array#wrap in generators action methods
symbol nodes. Fixes rails#4585
Conflicts: activesupport/test/callbacks_test.rb
date_select does not work when day is discarded, include blank option is enabled and struct date itself is nil.
|
Sorry =/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4453 and #4633