Optionally skip bundler-audit #55714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipkayhil
reviewed
Sep 19, 2025
| template "application.rb" | ||
| template "environment.rb" | ||
| template "bundler-audit.yml" | ||
| template "bundler-audit.yml" unless options[:skip_bundler_audit] |
There was a problem hiding this comment.
Suggested change
| template "bundler-audit.yml" unless options[:skip_bundler_audit] | |
| template "bundler-audit.yml" unless skip_bundler_audit? |
Is there a reason to use options here?
| end | ||
|
|
||
| if !bundle_audit_config_exist | ||
| if !@options[:skip_bundler_audit] && !bundle_audit_config_exist |
that-jill
force-pushed
the
jk/conditional-bundler-audit
branch
from
136209f to
722f442
Compare
|
Tests are broken |
that-jill
force-pushed
the
jk/conditional-bundler-audit
branch
from
a65d957 to
10040f8
Compare
Running `bin/rails app:update` with Rails 8.1 adds bin/bundler-audit and config/bundler-audit.yml even if it's not in the Gemfile already. This checks whether bundler_audit is in the bundle and otherwise skips for the app generator. Adds config option to skip bundler-audit in new applications. Extends --minimal option to include bundler-audit Updates changelog Updates test assertions re: bundler-audit; the #generate_test_dummy method skips bundle and bundler-audit, so it should not be expected to be present
that-jill
force-pushed
the
jk/conditional-bundler-audit
branch
from
10040f8 to
0a0addc
Compare
|
Sorry for the delay -- all comments have been addressed and tests are green :) |
|
Amazing, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Was testing the 8.1 upgrade and noticed that bundler-audit files got added when running
bin/rails app:update, regardless of whether that gem was included in the gemfile.Since the new/update passes are tightly coupled, this also adds the option to
--skip-bundler-auditwhen generating a new app. This flag was passed in to the--minimalgenerator option as well.Additional information
Added automated testing for newly-generated apps and tested with an app I'm using to test the Rails 8.1 upgrade.
Checklist
[Fix #issue-number]