Use Turbo.fetch to prevent page refreshes bounces #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Merged @jorgemanrubia! |
Collaborator
|
We will have to fix this in https://github.com/rails/request.js, though |
Collaborator
|
@jorgemanrubia just so I fully understand this, essentially, it would be ideal for request.js to always use Turbo's fetch when available, not just for a specific response kind? |
Collaborator
|
Ok, changing it on the request.js repo, here is the PR rails/request.js#90 |
Collaborator
|
Ok, released v13 of the js package https://github.com/rails/request.js/releases/tag/v0.0.13, and v14 of the gem https://github.com/rails/requestjs-rails/releases/tag/v0.0.14 |
Contributor
Author
|
Will send the follow-up PR to Fizzy, thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from fizzy as requested by @jorgemanrubia at basecamp/fizzy@ebf8490