Fix 5 0 for rails 5 #375
Merged
Fix 5 0 for rails 5 #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These config options changed in Rails so they were causing errors in the sass-rails tests. This updates the config options with the expected settings.
Gems are no longer allowed to leave the default TODO's in place. This replaces all the ones that can't be TODO anymore with something that is acceptable. ``` Error: bundler: failed to load command: rails (Users/eileen/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bin/rails) Gem::InvalidSpecificationException: The gemspec at /private/var/folders/fy/rml6_y9x3b392jpmpy160g7r0000gn/T/d20160630-25961-h3mf6o/engine_project.gemspec is not valid. Please fix this gemspec. The validation error was '"FIXME" or "TODO" is not an author' ```
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (NB. this repo may be misconfigured) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc/ @rafaelfranca