Consolidate project_version and badge_version
#271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 5042d1e, the value of `ENV["HORO_BADGE_VERSION"]` is preferred over the value of `ENV["HORO_PROJECT_VERSION"]`. Therefore, we can consolidate the `project_version` and `badge_version` helpers. Note that while `ENV["HORO_BADGE_VERSION"]` has the format we desire, `ENV["HORO_PROJECT_VERSION"]` is the more obvious and preferable name. After these changes is released, we can encourage consumers (namely, Rails) to set `ENV["HORO_PROJECT_VERSION"]` with the same value as `ENV["HORO_BADGE_VERSION"]` and then to drop `ENV["HORO_BADGE_VERSION"]` altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 5042d1e, the value of
ENV["HORO_BADGE_VERSION"]is preferred over the value ofENV["HORO_PROJECT_VERSION"]. Therefore, we can consolidate theproject_versionandbadge_versionhelpers.Note that while
ENV["HORO_BADGE_VERSION"]has the format we desire,ENV["HORO_PROJECT_VERSION"]is the more obvious and preferable name. After these changes is released, we can encourage consumers (namely, Rails) to setENV["HORO_PROJECT_VERSION"]with the same value asENV["HORO_BADGE_VERSION"]and then to dropENV["HORO_BADGE_VERSION"]altogether.