Add break opportunities in long names for mobile #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When wrapping text, Safari and Chrome do not consider `/` nor `:` as word break characters. Firefox considers `/` as a word break character but not `:`. This can lead to horizontal overflow issues with long file paths and module names on mobile. This commit adds a `full_name` helper to insert word-break opportunities into file paths and module names. It also revises the `link_to` helper to do the same when given an `RDoc::CodeObject`. The helpers insert `<wbr>` tags which tell the browser that the text can be wrapped at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wrapping text, Safari and Chrome do not consider
/nor:as word break characters. Firefox considers/as a word break character but not:. This can lead to horizontal overflow issues with long file paths and module names on mobile.This commit adds a
full_namehelper to insert word-break opportunities into file paths and module names. It also revises thelink_tohelper to do the same when given anRDoc::CodeObject. The helpers insert<wbr>tags which tell the browser that the text can be wrapped at that point.(The above screenshots were taken using Chrome's developer tools on desktop. The "Before" screenshots may vary between different browsers.)