Increase top margin for long list items #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List items inside `#content` use `var(--space-sm)` as their top margin because `var(--space)` looks too disjointed for single-paragraph items, especially single-line items. However, when a list item contains an element that itself has a `var(--space)` top margin, the list item's top margin looks mismatched. This commit adds a style tweak such that all list items in a list with any multi-paragraph items will use `var(--space)` for their top margin. (More specifically, when any item contains a paragraph plus another block level element, such as another paragraph or a code block.) Unfortunately, this enhancement does not currently work in Firefox because it relies on the `:has()` selector. However, it is only a minor enhancement, and Firefox plans to support `:has()` in the near future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List items inside
#contentusevar(--space-sm)as their top margin becausevar(--space)looks too disjointed for single-paragraph items, especially single-line items. However, when a list item contains an element that itself has avar(--space)top margin, the list item's top margin looks mismatched.This commit adds a style tweak such that all list items in a list with any multi-paragraph items will use
var(--space)for their top margin. (More specifically, when any item contains a paragraph plus another block level element, such as another paragraph or a code block.)Unfortunately, this enhancement does not currently work in Firefox because it relies on the
:has()selector. However, it is only a minor enhancement, and Firefox plans to support:has()in the near future.