Fix link to crawler file #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `generate_file_links` method generates a `panel/links.html` file for search engines to crawl. When `panel/index.html` was converted to `_panel.rhtml` in 4c5d4a0, the link to `panel/links.html` was broken. Though the value of this file may be debatable, it definitely provides zero value if it is unreachable. This commit fixes the broken link. This commit also renames the `generate_search_index` method to `generate_file_links`, and renames `search_index.rhtml` to `file_links.rhtml` so that it won't be confused with `search_index.js`, which is entirely unrelated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
generate_file_linksmethod generates apanel/links.htmlfile for search engines to crawl. Whenpanel/index.htmlwas converted to_panel.rhtmlin 4c5d4a0, the link topanel/links.htmlwas broken. Though the value of this file may be debatable, it definitely provides zero value if it is unreachable. This commit fixes the broken link.This commit also renames the
generate_search_indexmethod togenerate_file_links, and renamessearch_index.rhtmltofile_links.rhtmlso that it won't be confused withsearch_index.js, which is entirely unrelated.