Skip to content

Improve code language detection for ERB and HTML #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanhefner merged 1 commit into from
Aug 28, 2023
Merged

Improve code language detection for ERB and HTML #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sdoc/postprocessor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def guess_code_language(code)
else
"yaml"
end
when /^ *<[%a-z]/i
when /^ *<[%a-z]|%>$|<\/\w+>$/i
"erb" # also highlights HTML
else
"ruby"
Expand Down
13 changes: 13 additions & 0 deletions spec/postprocessor_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,10 @@
<%= 1 + 1 %>
ERB

_(SDoc::Postprocessor.guess_code_language(<<~ERB)).must_equal "erb"
1 + 1 = <%= 1 + 1 %>
ERB

_(SDoc::Postprocessor.guess_code_language(<<~ERB)).must_equal "erb"
<% x = 1 + 1 %>
ERB
Expand All @@ -413,6 +417,10 @@
_(SDoc::Postprocessor.guess_code_language(<<~HTML)).must_equal "erb"
<p>1 + 1 = 2</p>
HTML

_(SDoc::Postprocessor.guess_code_language(<<~HTML)).must_equal "erb"
1 + 1 = <span>2</span>
HTML
end

it "guesses erb for HTML that includes ERB" do
Expand All @@ -432,6 +440,11 @@
Object.new # => #<Object>
RUBY

_(SDoc::Postprocessor.guess_code_language(<<~RUBY)).must_equal "ruby"
Pathname("/span")
# => #<Pathname:/span>
RUBY

_(SDoc::Postprocessor.guess_code_language(<<~RUBY)).must_equal "ruby"
image_tag("image.png")
# => <img src="/assets/image.png" />
Expand Down