Skip to content

Conversation

@seuros
Copy link
Member

@seuros seuros commented Dec 31, 2023

Just noticed something - when you add solid_cache, it ends up adding in the whole Rails stack.

This is kind of causing a bit of a mix-up because some monitoring and debug tools get activated when the gemlock has the unused gems (ex actioncable)

@seuros seuros force-pushed the main branch 4 times, most recently from fefb9ce to fb2fa61 Compare December 31, 2023 17:57
@seuros seuros marked this pull request as ready for review December 31, 2023 18:02
@djmb
Copy link
Collaborator

djmb commented Jan 4, 2024

Thanks for the PR @seuros!

There are some merge conflicts here, but there's also #115 to be merged. Once the conflicts are resolved and that's merged can I get you to rebase this?

@seuros seuros force-pushed the main branch 3 times, most recently from 486baca to 0380a3f Compare January 4, 2024 11:43
@seuros
Copy link
Member Author

seuros commented Jan 4, 2024

@djmb done

@djmb djmb merged commit 9631687 into rails:main Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants