Skip to content

Conversation

@berkos
Copy link
Contributor

@berkos berkos commented Jan 1, 2024

👋 Thanks for the review in advance.

  • Adds Rails supported Ruby versions including 3.3 in the CI matrix.
  • It also updates the appraisals to update Nokogiri as on Ruby 3.3
    the current version on *.lock files was failing as below:
nokogiri-1.15.4-x86_64-linux requires ruby version < 3.3.dev, >= 2.7, which is
incompatible with the current version, 3.3.0

@berkos berkos changed the title Add Ruby 3.3 on CI and update appraisals Add Rails supported Ruby versions on CI and update appraisals Jan 1, 2024
@djmb
Copy link
Collaborator

djmb commented Jan 4, 2024

That's a lot of checks now since we have the three databases to test against. There are a few flaky tests so this will be a good push to iron those out 😅

@berkos - there are some merge conflicts now. If you could resolve them I'll merge this in

@berkos
Copy link
Contributor Author

berkos commented Jan 16, 2024

That's a lot of checks now since we have the three databases to test against. There are a few flaky tests so this will be a good push to iron those out 😅

@berkos - there are some merge conflicts now. If you could resolve them I'll merge this in

@djmb Sorry for the delay, conflicts have now been resolved. 🙂

@djmb djmb merged commit d90a5c0 into rails:main Jan 18, 2024
@berkos berkos deleted the ci-ruby-3.3 branch January 18, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants