Replace expiry counter with random chance #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the lifespan of a process is smaller than an expiry cycle then it may not trigger the expiry process often enough. We mitigate this a little bit by pre-filling the counter with a random number, but that means that on average a process still needs to survive for half an expiry cycle. Instead lets trigger expiry randomly, but keep the same overall frequency. This will always give us an expiry rate proportional to the number of writes whatever the process length.
djmb
force-pushed
the
probabilistic-expiry
branch
from
39c8e92 to
b7b14b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the lifespan of a process is smaller than an expiry cycle then it may not trigger the expiry process often enough. We mitigate this a little bit by pre-filling the counter with a random number, but that means that on average a process still needs to survive for half an expiry cycle.
Instead lets trigger expiry randomly, but keep the same overall frequency. This will always give us an expiry rate proportional to the number of writes whatever the process length.
Fixes #91