Skip to content

Should wrap_in_app_executor use Reloader or Executor? #726

@ghiculescu

Description

@ghiculescu

This isn't necessarily an issue (yet), more of a question.

SolidQueue.app_executor becomes Rails.application.executor here.

According to https://guides.rubyonrails.org/threading_and_code_execution.html#reloader and https://guides.rubyonrails.org/threading_and_code_execution.html#wrapping-application-code, the appropriate thing to use for job queues is reloader not executor. So Rails.application.reloader.

I don't understand Rails internals well enough to understand the distinction or why it matters, but wanted to put the question to the group in case it was an oversight.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions