Second attempt reduce flakiness of processes_lifecycle_test.rb
#654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-schlickmann
changed the title
processes_lifecycle_test.rbprocesses_lifecycle_test.rb
p-schlickmann
force-pushed
the
flaky-processes-lifecycle-test
branch
from
c1e5f34 to
613a110
Compare
p-schlickmann
force-pushed
the
flaky-processes-lifecycle-test
branch
from
0144b86 to
0d2f05f
Compare
|
@rosa Seems to be working now! The failed test is unrelated to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt to reduce the flakiness of
processes_lifecycle_test.rb.I started using the same logic from #L65-L85.
According to the comment, we should actually check for
:readyrather than:claimed.Issue #602