Skip to content

Second attempt reduce flakiness of processes_lifecycle_test.rb #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

Second attempt reduce flakiness of processes_lifecycle_test.rb #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions test/integration/processes_lifecycle_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,25 +123,22 @@ class ProcessesLifecycleTest < ActiveSupport::TestCase
no_pause = enqueue_store_result_job("no pause")
pause = enqueue_store_result_job("pause", pause: SolidQueue.shutdown_timeout + 10.second)

wait_while_with_timeout(1.second) { SolidQueue::ReadyExecution.count > 0 }
wait_while_with_timeout(1.second) { SolidQueue::ReadyExecution.count > 1 }

signal_process(@pid, :TERM, wait: 0.5)
signal_process(@pid, :TERM, wait: 0.5.second)
wait_for_jobs_to_finish_for(2.seconds, except: pause)

sleep(SolidQueue.shutdown_timeout + 0.5.second)
wait_while_with_timeout!(SolidQueue.shutdown_timeout + 1.second) { process_exists?(@pid) }
assert_not process_exists?(@pid)

assert_completed_job_results("no pause")
assert_job_status(no_pause, :finished)

# This job was left claimed as the worker was shutdown without
# a chance to terminate orderly
assert_started_job_result("pause")
assert_job_status(pause, :claimed)

# The process running the long job couldn't deregister, the other did
assert_registered_workers_for(:background)

# Now wait until the supervisor finishes for real, which will complete the cleanup
wait_for_process_termination_with_timeout(@pid, timeout: 1.second)
# Workers were shutdown without a chance to terminate orderly, but
# since they're linked to the supervisor, the supervisor deregistering
# also deregistered them and released claimed jobs
assert_job_status(pause, :ready)
assert_clean_termination
end

Expand Down
Loading