Skip to content

Conversation

@kaspth
Copy link

@kaspth kaspth commented Sep 17, 2014

Hi, Peter! Great work so far. I have a suggestion 😄

For the simple cases where a model is backed by a form (e.g. a User has a UserForm) the model can be inferred based on the name of the form.

I've also made the regex strip Fixture, which really should be changed to having the form fixtures not having a Fixture suffix, but this demonstrates my thinking.

It seems I also have stripped some whitespace for you 😄

@m-Peter
Copy link

m-Peter commented Sep 17, 2014

That's cool @kaspth . @carlosantoniodasilva proposed this suggestion during the GSoC period, but we were working on other things at that time. I'm glad that you implemented this suggestion on your own. I'm assuming that you have a basic understanding of the code base, since you've implemented this feature on your own. Any feedback in terms of readability(and in general) will be valuable.

@kaspth
Copy link
Author

kaspth commented Sep 17, 2014

@m-Peter I'm not that familiar with the code base, but sure I have a basic understanding.
I'd love to give feedback. However, I can't open issues on here. Can you add me to the project (or open it up in general)? 😄

@kirs
Copy link

kirs commented Sep 17, 2014

👍

@guilleiguaran
Copy link
Member

@kaspth can you rebase this? 😄

kaspth added a commit that referenced this pull request Nov 25, 2014
Infer model from form name.
@kaspth kaspth merged commit 7484b30 into railsgsoc:master Nov 25, 2014
@kaspth kaspth deleted the infer-model branch November 25, 2014 16:19
@kaspth
Copy link
Author

kaspth commented Nov 25, 2014

@guilleiguaran rebased and merged. I hope that's okay 😄

@guilleiguaran
Copy link
Member

@kaspth 👍

wazery pushed a commit to wazery/activeform that referenced this pull request Nov 25, 2014
@kirs
Copy link

kirs commented Nov 26, 2014

Am I right that https://github.com/rails/activeform/blame/master/README.md#L22 line can be removed now? @kaspth

@kaspth
Copy link
Author

kaspth commented Nov 26, 2014

It can. But we need some more text explaining how Active Form infers the model name.

Kasper

Den 26/11/2014 kl. 17.03 skrev Kir Shatrov notifications@github.com:

Am I right that https://github.com/rails/activeform/blame/master/README.md#L22 line can be removed now? @kaspth


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants