Test file upload #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Active form is an experiment and the api is not ready yet. I don't recommend to use it right now. |
Author
|
Sure, I'm just willing to contribute more. |
kirs
force-pushed
the
test-file-upload
branch
from
7b615c3 to
c41c248
Compare
Author
|
@guilleiguaran ok to merge? |
|
Seems good to me!!! |
|
I don't think it's ok to just use a picture of someone's face! Especially without asking. Why not use a text file instead? |
kirs
force-pushed
the
test-file-upload
branch
from
c41c248 to
508f1ed
Compare
Author
|
@kaspth fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to use activeform for file uploads and I didn't find test coverage for that.