Support railway init projectid#15
Merged
JakeCooper merged 2 commits intomasterfrom Oct 7, 2020
Merged
Conversation
Contributor
coffee-cup
commented
Oct 5, 2020
coffee-cup
commented
- Support railway init
- Prompt for environment if there is more than 1 in a project
- Show "Project not found" error instead of "graphql: Not authorised" if fetching a project fails
JakeCooper
reviewed
Oct 5, 2020
|
|
||
| err = h.saveProjectAndEnvironment(ctx, project) | ||
| if err != nil { | ||
| return nil |
| if len(req.Args) > 0 { | ||
| // projectID provided as argument | ||
| projectID := req.Args[0] | ||
| return h.saveProjectWithID(ctx, projectID) |
Contributor
There was a problem hiding this comment.
Can we keep these to following the common interface of taking a context + a CommandRequest?
projectId should be retrievable from req.Args[0]
| } | ||
| if err := g.gqlClient.Run(ctx, gqlReq, &resp); err != nil { | ||
| return nil, err | ||
| return nil, errors.ProjectNotFound |
Contributor
There was a problem hiding this comment.
Any reason we're masking the error from users?
Additionally, it would be really good to have error reporting in the CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.