Re-Enable up for Alpha#25
Merged
JakeCooper merged 5 commits intomasterfrom Oct 16, 2020
Merged
Conversation
Contributor
JakeCooper
commented
Oct 15, 2020
JakeCooper
commented
- Up enabled for Alpha Users
coffee-cup
reviewed
Oct 15, 2020
| return nil | ||
| } | ||
|
|
||
| func (c *Controller) Up(ctx context.Context) error { |
Contributor
There was a problem hiding this comment.
If this is only enabled for admins, should we also prevent non-admins from using this command?
Contributor
Author
There was a problem hiding this comment.
That would mean exposing an endpoint to determine if a user is or isn't an admin. Too much leakage IMO.
Contributor
There was a problem hiding this comment.
We already have a gql endpoint setup to fetch the user. We could a also return the isAdmin flag there. Alternatively, we could just check if there is any user config defined (admins will obviously be logged in)
Co-authored-by: Jake Runzer <jakerunzer@gmail.com>
coffee-cup
approved these changes
Oct 16, 2020
sdan
pushed a commit
that referenced
this pull request
Oct 16, 2020
* Re-Enable up for Alpha * Update gateway/up.go Co-authored-by: Jake Runzer <jakerunzer@gmail.com> * Ignore node_modules * Gitignore respected Co-authored-by: Jake Runzer <jakerunzer@gmail.com>
sdan
pushed a commit
that referenced
this pull request
Oct 16, 2020
* Re-Enable up for Alpha * Update gateway/up.go Co-authored-by: Jake Runzer <jakerunzer@gmail.com> * Ignore node_modules * Gitignore respected Co-authored-by: Jake Runzer <jakerunzer@gmail.com>
sdan
pushed a commit
that referenced
this pull request
Oct 16, 2020
* Re-Enable up for Alpha * Update gateway/up.go Co-authored-by: Jake Runzer <jakerunzer@gmail.com> * Ignore node_modules * Gitignore respected Co-authored-by: Jake Runzer <jakerunzer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.