Add a command to restart a deployment #687
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coffee-cup
reviewed
Jan 7, 2026
Contributor
coffee-cup
left a comment
coffee-cup
left a comment
There was a problem hiding this comment.
Sorry for the delay here. This mostly looks good. Would love to merge soon!
| .ok_or_else(|| anyhow!("The service specified doesn't exist in the current environment"))?; | ||
|
|
||
| if let Some(ref latest) = service_in_env.node.latest_deployment { | ||
| if latest.can_redeploy { |
Contributor
There was a problem hiding this comment.
We don't need this check for restarting
Comment on lines
+94
to
+135
| // Wait for healthchecks via latest deployment status | ||
| let max_wait = Duration::from_secs(300); | ||
| let poll_interval = Duration::from_secs(2); | ||
| let start = std::time::Instant::now(); | ||
| loop { | ||
| if start.elapsed() > max_wait { | ||
| spinner.finish_and_clear(); | ||
| bail!("Timed out waiting for health checks after restart"); | ||
| } | ||
|
|
||
| let resp = post_graphql::<queries::LatestDeployment, _>( | ||
| &client, | ||
| configs.get_backboard(), | ||
| queries::latest_deployment::Variables { | ||
| service_id: service.node.id.clone(), | ||
| environment_id: linked_project.environment.clone(), | ||
| }, | ||
| ) | ||
| .await?; | ||
|
|
||
| let si = resp.service_instance; | ||
| if let Some(ld) = si.latest_deployment { | ||
| match ld.status { | ||
| queries::latest_deployment::DeploymentStatus::SUCCESS => { | ||
| spinner.finish_with_message(format!( | ||
| "Restart successful for service {}", | ||
| service.node.name.green() | ||
| )); | ||
| return Ok(()); | ||
| } | ||
| queries::latest_deployment::DeploymentStatus::FAILED | ||
| | queries::latest_deployment::DeploymentStatus::CRASHED => { | ||
| spinner.finish_and_clear(); | ||
| bail!("Restart completed but health checks failed"); | ||
| } | ||
| _ => {} | ||
| } | ||
| } | ||
|
|
||
| tokio::time::sleep(poll_interval).await; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Is this intended to be here? Deployment restarts don't perform a healthcheck, so this is not relevant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
railway restartwhich restarts a deployment. This has been tested.Resolves #616.
Also resolves
cargo clippyerrors.