fix: dev --no-tui stops services on quit#764
Merged
coffee-cup merged 1 commit intomasterfrom Jan 14, 2026
Merged
Conversation
Absorb additional Ctrl+C presses during shutdown to prevent abrupt termination before child processes can be properly stopped. Add spinners to show shutdown progress for both code and image services.
coffee-cup
force-pushed
the
jr/dev-notui-cleanup
branch
from
82bce59 to
391f77c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
railway dev --no-tui, pressing Ctrl+C would not stop the services. The issue was that after the first Ctrl+C broke out of the log loop, there was no signal handler active. If users pressed Ctrl+C again, the process was killed immediately by SIGINT before shutdown could complete, leaving orphaned child processes.The fix adds a background signal handler that absorbs additional Ctrl+C presses during shutdown, preventing abrupt termination and ensuring child processes are properly stopped. Now both TUI and non-TUI modes behave consistently.