Merged
Conversation
|
🚅 Deployed to the railpack-pr-92 environment in railpack
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of copying the input states onto the first state, this PR changes that behaviour to use a
llb.Mergeoperation. This is more efficient, especially when the merge op is the final node in the build graph (which it always will be for the deploy inputs).Because of how merging works, we are copying each input into a separate scratch layer. Because of this, we need to avoid copying the
.local state multiple times. This is where all the snapshot file changes comes from.Ref: https://github.com/moby/buildkit/blob/1a1ee09d1c3e2eabf0f37b980ac79acce0c17703/docs/dev/merge-diff.md