feat(animations): create animation utilities for fade effects#70
Merged
feat(animations): create animation utilities for fade effects#70
Conversation
- Add util/animations.lua with FadeIn, FadeOut, StopFade functions - Uses WoW AnimationGroup API for smooth alpha transitions - Includes animation caching per frame for performance - Add LuaLS type annotations in definitions.lua - Register animations.lua in hybar.toc Closes #42 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds reusable fade animation utilities for the hybar addon using WoW's AnimationGroup API. The implementation provides FadeIn(), FadeOut(), and StopFade() functions with animation caching for performance optimization.
Changes:
- Created new animation utility module with fade effects
- Added animation group caching per frame to avoid recreating animations
- Integrated type annotations for LuaLS support
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| util/animations.lua | New module implementing fade-in, fade-out, and stop animation functions with caching |
| hybar.toc | Added util/animations.lua to the load order after util/util.lua |
| definitions.lua | Added LuaLS type annotations for the animations API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
util/animations.luawith reusable animation functionsFadeIn(),FadeOut(), andStopFade()using WoW AnimationGroup APIdefinitions.luaTest plan
Closes #42
🤖 Generated with Claude Code