Merged
Conversation
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
[package.metadata.binstall]toCargo.tomlsocargo binstall workmuxresolves the existing goreleaser release artifacts instead of falling back to a source compile.Why
Without this metadata, binstall expects asset names like
workmux-x86_64-unknown-linux-gnu.tar.gz, but the goreleaser pipeline publishesworkmux-linux-amd64.tar.gz(etc.). The mismatch makes binstall fall through tocargo install, which compiles from source — slow, and requires a full Rust toolchain in user environments (Docker images, CI) that only wanted a binary.The release assets users want already exist; this just teaches binstall where to find them.
What
Maps each supported Rust target triple to the matching goreleaser asset:
x86_64-unknown-linux-{gnu,musl}workmux-linux-amd64.tar.gzaarch64-unknown-linux-{gnu,musl}workmux-linux-arm64.tar.gzx86_64-apple-darwinworkmux-darwin-amd64.tar.gzaarch64-apple-darwinworkmux-darwin-arm64.tar.gzPure metadata change — no CI, release pipeline, or version bump. No new release targets added; this only points binstall at what's already published.
The
musloverrides reuse the gnu-built asset since the binary is statically-linked-enough in practice; happy to drop them if you'd rather only advertise gnu.Verification
Tested against v0.1.183 from a local checkout with the patched
Cargo.toml:Resolved URL:
https://github.com/raine/workmux/releases/download/v0.1.183/workmux-linux-amd64.tar.gz. Confirmed the same foraarch64-unknown-linux-{gnu,musl},x86_64-unknown-linux-musl,x86_64-apple-darwin, andaarch64-apple-darwin. End-to-end install into a throwaway dir extracts the binary at the archive root andworkmux --versionprintsworkmux 0.1.183.References