Skip to content

[A23-7] [LOW] LibFlow.flow NatSpec references IInterpreterStoreV1 but param is V2 #377

@thedavidmeister

Description

@thedavidmeister

Severity

LOW

File

src/lib/LibFlow.sol

Location

Line 139 (NatSpec on flow() function).

Finding

The @param interpreterStore doc references IInterpreterStoreV1, but the actual parameter type (line 141) and the import (line 16) are both IInterpreterStoreV2.

    /// @param interpreterStore The `IInterpreterStoreV1` to set state on.
    function flow(FlowTransferV1 memory flowTransfer, IInterpreterStoreV2 interpreterStore, uint256[] memory kvs)

The doc was not updated when the import was migrated from V1 to V2, leaving a stale type reference in the only public-facing description of the parameter.

Suggested fix

Change IInterpreterStoreV1 to IInterpreterStoreV2 in the NatSpec on line 139.

Metadata

Metadata

Assignees

No one assigned

    Labels

    auditAudit findinglowSeverity: lowpass3Audit Pass 3: Documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions