Skip to content

test UnsupportedFlowInputs revert in flowInit#441

Open
thedavidmeister wants to merge 1 commit intomainfrom
2026-05-04-issue-310-320-unsupported-flow-inputs-test
Open

test UnsupportedFlowInputs revert in flowInit#441
thedavidmeister wants to merge 1 commit intomainfrom
2026-05-04-issue-310-320-unsupported-flow-inputs-test

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

Summary

Pins the flowInit guard that rejects any non-zero flowInputs byte returned by the deployer.

Flow.sol:210 reverts with UnsupportedFlowInputs when flowInputs != 0. No prior test exercised this branch; the only mock IO strings used in tests had flowInputs == 0, so a regression here would not have been caught.

The new fuzz test mocks the deployer to return a non-zero flowInputs byte and asserts the revert selector. Mutation verified: inverting the check (!= 0== 0) makes the test fail; reverting passes.

Closes #310 #320.

Test plan

  • testFlowConstructionRevertsOnNonZeroFlowInputs — 100 fuzz runs, all pass
  • mutation: invert the check in Flow.sol:210 → test fails
  • static via rainix-sol-static

🤖 Generated with Claude Code

Pins the guard that rejects any non-zero flowInputs byte returned by
the deployer. Mutation verified: inverting the check (`!= 0` → `== 0`)
makes the test fail; reverting passes.

Closes #310 #320.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 43 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 05c9441a-398f-4424-8126-4b2031ee56ed

📥 Commits

Reviewing files that changed from the base of the PR and between ceaea3c and 4c23090.

📒 Files selected for processing (1)
  • test/src/concrete/Flow.construction.t.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-04-issue-310-320-unsupported-flow-inputs-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 12 minutes and 43 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[A02-1] [MEDIUM] UnsupportedFlowInputs has no test coverage

1 participant