deploy: always sign with PRIVATE_KEY (never PRIVATE_KEY_DEV)#473
Conversation
|
Warning Review limit reached
More reviews will be available in 50 minutes and 35 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…e-nix-action) The DeterminateSystems magic-nix-cache service was sunset; its daemon now 418s and fails every build. Swap for nix-quick-install + cachix (rainlanguage) + cache-nix-action. CI-only; keeps submodules + the bespoke matrix.
…UtilsAbstractTest refactor) Lines 40 + 59 still used the removed bare generateFlowStack(transfer) wrapper; align with every other flow test (and this file's own line 20) by calling the library form LibStackGeneration.generateFlowStack(Sentinel.unwrap(RAIN_FLOW_SENTINEL), transfer). main hasn't compiled since the refactor — it was masked by the dead magic-nix-cache.
|
Reviewed 9d47b64: APPROVE — PRIVATE_KEY (drops PRIVATE_KEY_DEV, the last org reference); modernize nix setup (dead magic-nix-cache -> nix-quick-install + cachix + cache-nix-action, fixes HTTP 418); fix Flow.time.t.sol generateFlowStack calls (lines 40+59 missed in the FlowUtilsAbstractTest refactor — main hadn't compiled since, masked by the dead cache); forge fmt. All standard-tests green. |
1 participant
Per project policy, deploy workflows always sign with
secrets.PRIVATE_KEY. Replaces thegithub.ref == 'refs/heads/main' && secrets.PRIVATE_KEY || secrets.PRIVATE_KEY_DEVfallback in: manual-sol-artifacts.yaml rainix.yamlFresh PR off current main (supersedes the stale #472, which was based on a pre-FlowTest-refactor main and no longer compiled). Last repo referencing the org
PRIVATE_KEY_DEVsecret, so this clears it for deletion.