soldeer migration#7
Conversation
Mirrors rain.solmem, rain.math.binary, rain.math.saturating. Closes #6. - foundry.toml: libs="dependencies", [dependencies] forge-std=1.16.1, [soldeer] recursive_deps=false - forge-std submodule and .gitmodules removed - Source AND test imports updated to forge-std-1.16.1/src/* (LibRainDeploy itself imports Vm and console2 from forge-std for forge scripting cheatcodes) - .soldeerignore with depth-anchored patterns - REUSE.toml extended for .soldeerignore, remappings.txt, soldeer.lock - CI: drop submodules:recursive, drop sol-prelude, add forge soldeer install before each task; static job moved to rainix's reusable - Publish workflow: thin wrapper calling rainix's reusable - flake bumped; default devShell now points at sol-shell - README rewritten Verified: forge test passes (30/30) on the soldeer-managed forge-std. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Soldeer installs forge-std under dependencies/forge-std-<version>/ rather than lib/forge-std/, so the previous filter no longer matched and slither was flagging forge-std internals (Vm.sol pragma range, console.sol naming) as project findings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Migrate from git submodules to soldeer, mirroring rain.solmem, rain.math.binary, and rain.math.saturating. Closes #6.
Note: rain.deploy ships deterministic Zoltu addresses to prod. Source-byte changes (even cosmetic) shift addresses. The only source-side change here is rewriting two import strings in
LibRainDeploy.solfromforge-std/...toforge-std-1.16.1/src/...— the resolved files are byte-identical, so the compiled creation code should be unchanged. Worth confirming the codehash on the PR before merging if any consumer pins ourLibRainDeploycreation code.Changes
libs=["dependencies"],[dependencies] forge-std="1.16.1",[soldeer] recursive_deps=false.gitmodulesremovedforge-std-1.16.1/src/*(LibRainDeploy itself imports Vm and console2 from forge-std for forge scripting cheatcodes).soldeerignorewith depth-anchored patterns.soldeerignore,remappings.txt,soldeer.locksubmodules:recursive, drop sol-prelude, addforge soldeer installbefore each task; static job moved to rainix's reusableTest plan
forge t estpasses (30/30) locally on the soldeer-managed forge-stdLibRainDeploycreation-code keccak unchanged vs main (Zoltu address invariant)🤖 Generated with Claude Code